bugfix: run tests with directAccess#9690
bugfix: run tests with directAccess#9690dblythy wants to merge 4 commits intoparse-community:alphafrom
Conversation
|
🚀 Thanks for opening this pull request! |
|
Just a note that I tried to remove |
|
That’s how you know it works, we can figure out what’s not supported with direct access: true |
|
Should we:
|
We could have a separate CI job with
Ideally pass all tests. We can always go back to the @mtrezza Your call |
|
We should parameterize the entire test suite. Similar to data providers in PHPUnit. That allows us to easily run |
We already have this with the configuration options in
If we do this are you ok with the build failing until all tests pass? |
|
Good if we already have some of the logic in place. I think it needs to be refactored a bit to make this parameterization feature clearer. It also may need handling of reconfigureServer in a test that tries to override the param, probably throw an error, as the param is managed by the test suite. Regarding failing workflow for directAcess: true, we could set it as non-required in the GitHub CI. That's not very elegant for reviewers. I think the param logic that we need to build will likely benefit from a per-file exclusion. Some test files just won't need to run multiple times with different param values. That way we can gradually include files that support directAccess: true without having the CI failing. |
|
What is the path forward for this PR? |
|
I believe we need a logic in the test suite that allows to:
A suggestion: const options = [
key: 'directAccess',
values: [
true,
false
],
// an optional list regex expression that allows to include or exclude files based on their filenames, default should be '.*' which runs on all tests
files: [
'.*'
]
]; |
|
As it stands there are a number of tests that fail with direct access on (they either need installationId or they aren't compatible at all) - how do you suggest approaching this? |
|
I think we could set the |
|
I'm not sure if it's possible to access the current spec file from within |
Why are you trying to do that?
How else can we know whether directAccess does not break anything? Like the recently reported bug. |
Pull Request
Issue
Closes: #8808
Approach
Tasks